Oh, right. I've been meaning to respond to you, Cap'n K.
Firstly, not sure if you've heard this or not, but a quick elements breakdown; elements only attach to your Triangle-based attacks, and which Triangle attacks they attach to depends on character. For example, Zuo Ci attaches elements on his S-S-S-S-T, his S-S-T, and has limited attachment on his S-S-S-T. Keep that in mind; these finishers will usually as a result do more damage. Some people don't have great element attachment (Lu Bu) while others do (Zuo Ci).
Attach Slay/Flash to all weapons you use. If your guy juggles well, add Fire/Air; if not, add Bolt/Ice. Bolt/Air is good on a few people, and there's a few other combos, but those are the primary two.
Range only applies to "melee physicals". So lasers, tossed weapons, etc., don't get the boost (this being said, max Range doubles your weapon's range. Very nice). Might and Brave work best on generals when used together (2.0x if you're using both and fighting a general; normally Brave is 1.4 on generals, Might is 1.4 in general. If you need to skimp on one, skimp on Brave.) Agility is pretty good but some people have some glitchiness with it. Generally shouldn't be a problem. (Sima Yi is the main one I remember with this issue.)
Rage is practically useless. Drain isn't that good unless you've got massive area with your attacks to hit as many grunts as possible. Same for Absorb, but Absorb has usefulness a bit more for the people who use their Musou bar.
As for people, I don't know who you're using; if you want character-specific advice I can try to provide. If you want to know anything else I'll try to help.
